CVS commit: src/sys/arch/mac68k/dev

[Rin Okuyama]

Hi,

Can you please localize this quirk only for the affected machines?
It seems too much to me, to have 5 sec delay for irrelevant machines.

Thanks,
rin

Module Name: src
Committed By: nat
Date: Sat Sep 14 20:56:51 UTC 2024
src/sys/arch/mac68k/dev: adb.c
Allow a few seconds for adb devices to settle.
The spin up of the floppy drive motor would cause a crash on my PowerBook
when adb was attached.
cvs rdiff -u -r1.59 -r1.60 src/sys/arch/mac68k/dev/adb.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Index: src/sys/arch/mac68k/dev/adb.c
diff -u src/sys/arch/mac68k/dev/adb.c:1.59 src/sys/arch/mac68k/dev/adb.c:1.60
--- src/sys/arch/mac68k/dev/adb.c:1.59 Sat Aug 7 16:18:57 2021
+++ src/sys/arch/mac68k/dev/adb.c Sat Sep 14 20:56:50 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: adb.c,v 1.59 2021/08/07 16:18:57 thorpej Exp $ */
+/* $NetBSD: adb.c,v 1.60 2024/09/14 20:56:50 nat Exp $ */
/*
* Copyright (C) 1994 Bradley A. Grantham
@@ -26,7 +26,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: adb.c,v 1.59 2021/08/07 16:18:57 thorpej Exp $");
+__KERNEL_RCSID(0, "$NetBSD: adb.c,v 1.60 2024/09/14 20:56:50 nat Exp $");
#include "opt_adb.h"
@@ -94,6 +94,9 @@ static void
adbattach(device_t parent, device_t self, void *aux)
{
+ printf("... Waiting 5 seconds for adb devices to settle.");
+ kpause("adb-slp", false, mstohz(5000), NULL);
+
adb_softintr_cookie = softint_establish(SOFTINT_SERIAL,
(void (*)(void *))adb_soft_intr, NULL);
printf("\n");

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de

[Rin Okuyama]

Thank you very much for kind & rapid response!!

rin

Module Name: src
Committed By: nat
Date: Wed Sep 18 01:34:08 UTC 2024
src/sys/arch/mac68k/dev: adb.c
The delay is only required for machines with built-in floppy drives.
I doubt the vibration from an external drive on the Duos would affect adb
before it attaches.
cvs rdiff -u -r1.61 -r1.62 src/sys/arch/mac68k/dev/adb.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Index: src/sys/arch/mac68k/dev/adb.c
diff -u src/sys/arch/mac68k/dev/adb.c:1.61 src/sys/arch/mac68k/dev/adb.c:1.62
--- src/sys/arch/mac68k/dev/adb.c:1.61 Wed Sep 18 01:29:02 2024
+++ src/sys/arch/mac68k/dev/adb.c Wed Sep 18 01:34:08 2024
@@ -1,4 +1,4 @@
-/* $NetBSD: adb.c,v 1.61 2024/09/18 01:29:02 nat Exp $ */
+/* $NetBSD: adb.c,v 1.62 2024/09/18 01:34:08 nat Exp $ */
/*
* Copyright (C) 1994 Bradley A. Grantham
@@ -26,7 +26,7 @@
*/
#include <sys/cdefs.h>
-__KERNEL_RCSID(0, "$NetBSD: adb.c,v 1.61 2024/09/18 01:29:02 nat Exp $");
+__KERNEL_RCSID(0, "$NetBSD: adb.c,v 1.62 2024/09/18 01:34:08 nat Exp $");
#include "opt_adb.h"
@@ -104,12 +104,6 @@ adbattach(device_t parent, device_t self
/* Reqired on machines with in-built trackballs. */
printf("... Waiting 5 seconds for adb devices to "
"settle.");

--
Posted automagically by a mail2news gateway at muc.de e.V.
Please direct questions, flames, donations, etc. to news-***@muc.de